Add the from method to parse from any Iterator#62
Merged
Conversation
TeXitoi
requested changes
Feb 10, 2018
| /// Gets the struct from any iterator such as a `Vec` of your making. | ||
| /// Print the error message and quit the program in case of failure. | ||
| fn from_any<I, T>(iter: I) -> Self where | ||
| Self: Sized, I: IntoIterator<Item = T>, T: Into<OsString> + Clone, |
Owner
There was a problem hiding this comment.
fn from_iter<I>(iter: I) -> Self
where
Self: Sized,
I: IntoIterator,
I::Item: Into<OsString> + Clone
{
//...
Owner
There was a problem hiding this comment.
That was not really about indentation, but about the name of the method and the useless generic.
Contributor
Author
There was a problem hiding this comment.
Ho ! I will update that, sorry, didn't see.
Contributor
Author
There was a problem hiding this comment.
done! Thanks for spotting this, didn't think about specializing the I::Item !
Owner
|
Thanks for the contribution ! You can update the change log. I'll do it a bit later if you don't have the time. |
TeXitoi
approved these changes
Feb 10, 2018
Owner
|
Pups, bad review :-( you didn't change the name to from_iter. I'll modify it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.